Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow config of timeout from configuration #429

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: allow config of timeout from configuration #429

merged 1 commit into from
Nov 5, 2024

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Oct 30, 2024

No description provided.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.82%. Comparing base (2a95938) to head (3e3e376).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config/config.go 72.00% 8 Missing and 6 partials ⚠️
internal/controller/http/v1/devices.go 0.00% 1 Missing ⚠️
internal/controller/http/v1/login.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   68.84%   68.82%   -0.03%     
==========================================
  Files          80       80              
  Lines        9000     9039      +39     
==========================================
+ Hits         6196     6221      +25     
- Misses       2486     2494       +8     
- Partials      318      324       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/config.go Outdated Show resolved Hide resolved
@rsdmike rsdmike force-pushed the config branch 2 times, most recently from 9f0a6f9 to a701746 Compare November 5, 2024 16:53
This PR also creates a config if one does not exist in ./config/ dir and
enables the user to specifiy a config file via command line.
@rsdmike rsdmike merged commit e9d5135 into main Nov 5, 2024
24 checks passed
@rsdmike rsdmike deleted the config branch November 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants