Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds an api to download audit/event logs #477

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: adds an api to download audit/event logs #477

merged 1 commit into from
Jan 9, 2025

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Jan 7, 2025

No description provided.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 33.07692% with 87 lines in your changes missing coverage. Please review.

Project coverage is 68.23%. Comparing base (b48f139) to head (7e5a3b8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/http/v1/devicemanagement.go 6.25% 60 Missing ⚠️
internal/mocks/export_mocks.go 16.66% 20 Missing ⚠️
internal/usecase/export/usecase.go 85.00% 4 Missing and 2 partials ⚠️
internal/controller/http/router.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   68.73%   68.23%   -0.51%     
==========================================
  Files          80       82       +2     
  Lines        9040     9167     +127     
==========================================
+ Hits         6214     6255      +41     
- Misses       2503     2587      +84     
- Partials      323      325       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsdmike rsdmike marked this pull request as ready for review January 8, 2025 22:29
@rsdmike rsdmike force-pushed the audit_log branch 2 times, most recently from 1dcecb1 to de38f1a Compare January 8, 2025 23:02
@madhavilosetty-intel
Copy link
Contributor

Commit message needs to be updated to reflect both audit and event log changes.

@rsdmike rsdmike changed the title feat: adds an api to get all audit logs feat: adds an api to download audit/event logs Jan 9, 2025
@rsdmike rsdmike enabled auto-merge (rebase) January 9, 2025 16:01
@rsdmike rsdmike merged commit f916a2a into main Jan 9, 2025
23 checks passed
@rsdmike rsdmike deleted the audit_log branch January 9, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants