Added latent heating for ice vapour deposition and included it in uni…

…t test
open-atmos · Oct 9, 2024 · 95cf76e · 95cf76e
1 parent 3a8cabc
commit 95cf76e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/PySDM/backends/impl_numba/methods/deposition_methods.py b/PySDM/backends/impl_numba/methods/deposition_methods.py
@@ -102,6 +102,9 @@ def body(
                         assert False
                     ambient_vapour_mixing_ratio[cid] += delta_rv_i
 
+                    delta_T = -delta_rv_i * latent_heat_sub / formulae.constants.c_pd
+                    ambient_temperature[cid] += delta_T 
+
                     x_old = formulae.diffusion_coordinate__x(ice_mass)
                     dx_dt_old = formulae.diffusion_coordinate__dx_dt(x_old, dm_dt)
                     x_new = formulae.trivia__explicit_euler(x_old, time_step, dx_dt_old)

diff --git a/tests/unit_tests/dynamics/test_vapour_deposition_on_ice.py b/tests/unit_tests/dynamics/test_vapour_deposition_on_ice.py
@@ -72,19 +72,24 @@ def test_iwc_lower_after_timestep(
 
 
     # act
+    T0   = temperature
     iwc_old = particulator.products["ice water content"].get().copy()
     particulator.run(steps=1)
+    T_new   = particulator.environment["T"][0]
     iwc_new = particulator.products["ice water content"].get().copy()
-
+    
     rv_new = particulator.environment["water_vapour_mixing_ratio"][0]
     # assert
     if water_mass < 0 and RHi != 1:
         if RHi > 1:
             assert (iwc_new > iwc_old).all()
             assert rv_new < rv0
+            assert T_new > T0 
         elif RHi < 1:
             assert (iwc_new < iwc_old).all()
             assert rv_new > rv0
+            assert T_new < T0
     else:
         assert (iwc_new == iwc_old).all()
         assert rv_new == rv0
+        assert T_new == T0