Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test coverage for Mesh; introduce Mesh.domain_bottom_surface_area; switch from volume to mass for rainfall counting; improve docstrings (default length of omitted dims, liquid/ice phase). closes #708 #1399

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Oct 8, 2024

No description provided.

@slayoo slayoo changed the title improve test coverage for Mesh; introduce Mesh.domain_bottom_surface_area; switch from volume to mass for rainfall counting; improve docstrings (default lengt of omitted dims, liquid/ice phase) improve test coverage for Mesh; introduce Mesh.domain_bottom_surface_area; switch from volume to mass for rainfall counting; improve docstrings (default length of omitted dims, liquid/ice phase) Oct 8, 2024
…area; switch from volume to mass for rainfall counting; improve docstrings (default lengt of omitted dims, liquid/ice phase)
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (fe4dabd) to head (13290e3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...SDM/products/displacement/surface_precipitation.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
+ Coverage   84.61%   84.62%   +0.01%     
==========================================
  Files         375      375              
  Lines        9247     9250       +3     
==========================================
+ Hits         7824     7828       +4     
+ Misses       1423     1422       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo changed the title improve test coverage for Mesh; introduce Mesh.domain_bottom_surface_area; switch from volume to mass for rainfall counting; improve docstrings (default length of omitted dims, liquid/ice phase) improve test coverage for Mesh; introduce Mesh.domain_bottom_surface_area; switch from volume to mass for rainfall counting; improve docstrings (default length of omitted dims, liquid/ice phase). closes #708 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant