Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default python 3.11 and cuda 12.2 updates #199

Merged
merged 23 commits into from
Nov 3, 2023

Conversation

ArchanaShinde1
Copy link
Contributor

Checklist before submitting

Description

Fixes # (issue).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one maintainer must review and approve.
  3. If any maintainer requests changes, they must be addressed.

@@ -117,7 +117,7 @@ class Argument(Enum):
type=str,
default=constants.DEFAULT_CUDA_VERS,
help='CUDA version to build for '
', such as "11.2" or "11.8".'))
', such as "11.2" or "11.8" or "12.2".'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove 11.2 here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated Show resolved Hide resolved
@ArchanaShinde1 ArchanaShinde1 force-pushed the default-py-cuda branch 3 times, most recently from 14a9c79 to b6f2e2d Compare November 3, 2023 09:50
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2d6f99d) 96.06% compared to head (a948220) 88.32%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   96.06%   88.32%   -7.74%     
==========================================
  Files          25       25              
  Lines        2184     2184              
==========================================
- Hits         2098     1929     -169     
- Misses         86      255     +169     
Flag Coverage Δ
unittests 88.32% <87.50%> (-7.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
open_ce/__init__.py 100.00% <100.00%> (ø)
open_ce/conda_env_file_generator.py 100.00% <100.00%> (ø)
open_ce/constants.py 100.00% <100.00%> (ø)
open_ce/inputs.py 95.03% <ø> (ø)
open_ce/utils.py 92.70% <100.00%> (-1.72%) ⬇️
open_ce/get_licenses.py 55.08% <0.00%> (-42.30%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArchanaShinde1 ArchanaShinde1 merged commit 03a0ca6 into open-ce:main Nov 3, 2023
7 checks passed
@ArchanaShinde1 ArchanaShinde1 deleted the default-py-cuda branch November 3, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants