[WIP] GPU/TPU resource-collector add-on #16
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: z1ens The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| agentSpec: | ||
| workload: | ||
| manifests: | ||
| - kind: ClusterRole |
There was a problem hiding this comment.
Could you try to minimize the rbac permission?
| clusterSet: global | ||
|
|
||
| --- | ||
| apiVersion: cluster.open-cluster-management.io/v1beta1 |
There was a problem hiding this comment.
suggest to move placement to a seperate yaml.
|
| IMAGE ?= resource-usage-collect-addon | ||
| IMAGE_REGISTRY ?= quay.io/haoqing | ||
| IMAGE_TAG ?= latest | ||
| IMAGE ?= resource-usage-collect-addon-template |
There was a problem hiding this comment.
It is not necessary to add the -template suffix.
| apiVersion: cluster.open-cluster-management.io/v1beta2 | ||
| kind: ManagedClusterSetBinding | ||
| metadata: | ||
| generation: 1 |
There was a problem hiding this comment.
the generation line is not needed.
| type: Placements | ||
| placements: | ||
| - name: placement-all | ||
| namespace: default |
There was a problem hiding this comment.
EOF, can we add a blank line for all yaml files?
|
it seems the DCO check is not working now. I will try to fix it. |
z1ens
changed the title
| @@ -12,4 +12,5 @@ | |||
| *.out | |||
|
|
|||
| # Dependency directories (remove the comment below to include it) | |||
| # vendor/ | |||
| # vendor/.DS_Store | |||
There was a problem hiding this comment.
should .DS_Store be in a new line? It is not a sub folder of the vendor, right?
REF: [GSoC 2024] Scheduling AI workload among multiple clusters ocm#369