E2E Tweaks/Fixes #279
Merged
E2E Tweaks/Fixes #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample output from the new And, similarly, the updated OperatorPolicy function: |
dhaiducek
force-pushed
the
e2e-fixes
branch
3 times, most recently
from
600e0a7
to
bad64e2
Compare
|
/hold to retry a bunch of times |
dhaiducek
commented
Jul 19, 2024
test/utils/utils.go
Outdated
| @@ -163,6 +159,14 @@ func Kubectl(args ...string) { | |||
| } | |||
| } | |||
|
|
|||
| func KubectlDelete(args ...string) { | |||
| deleteArgs := []string{ | |||
| "delete", "--wait=false", "--ignore-not-found", | |||
There was a problem hiding this comment.
I was hoping --wait=false would save some time, but it looks like the time to run the tests is similar.
|
Failure on run # 9: |
|
Failure in run # 8: |
|
Failure in run # 5 (hosted mode): |
mprahl
reviewed
Jul 25, 2024
|
Is the current test fail related to |
|
I like this changes Thanks Dale! |
|
/approve |
yiraeChristineKim
previously approved these changes
Jul 25, 2024
|
Failure in run # 11 (hosted mode): |
|
Hosted mode failures: |
|
Minimum K8s version failure (hosted mode): Latest K8s version failure: ^^^ At first I was worried my changes had caused it, but sure enough there was another event sent by the controller, so this failure is valid: |
Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
Includes: - `wait=false` to skip waiting for finalizers - `ignore-not-found` to ignore not found errors Signed-off-by: Dale Haiducek <[email protected]>
Does the compliance check directly, providing the status message on failure. Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
|
|
/unhold I'm not sure how useful it is to keep re-running these since the failures seem to be different each time. |
|
Hosted mode failure: |
Signed-off-by: Dale Haiducek <[email protected]>
mprahl
approved these changes
Aug 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0a0193e
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pause()util functionCheckComplianceStatus()function to also return the status message in the failure messagewait=falseto skip waiting for finalizers andignore-not-found