-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split kind.yaml workflow into parallel jobs #287
Split kind.yaml workflow into parallel jobs #287
Conversation
60a8699
to
9b6979e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold if you want to address any of the comments
LGTM! This sure has come a long way from when it ran serially! I have a couple minor comments, but I think they're more musings than anything that should block the PR.
Don't forget to update the Prow branch protections also. 🙂
The hosted mode tests and the "regular" tests were running in series, and each took about 20 minutes. Now they run in parallel in separate jobs, with a new job to merge their coverage data. Some other "quick" checks (like formatting, linting) were also moved to a separate job, which allows the tests to run even if there is a linting issue. Refs: - https://issues.redhat.com/browse/ACM-13032 Signed-off-by: Justin Kulikauskas <[email protected]>
9b6979e
to
9df8d8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The oddly failing test gives a chance to confirm if re-running will work with this artifacts upload/download stuff, so I guess that's nice 😆 |
8b0aecf
into
open-cluster-management-io:main
The hosted mode tests and the "regular" tests were running in series, and each took about 20 minutes. Now they run in parallel in separate jobs, with a new job to merge their coverage data. Some other "quick" checks (like formatting, linting) were also moved to a separate job, which allows the tests to run even if there is a linting issue.
Refs: