Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split kind.yaml workflow into parallel jobs #287

Conversation

JustinKuli
Copy link
Member

The hosted mode tests and the "regular" tests were running in series, and each took about 20 minutes. Now they run in parallel in separate jobs, with a new job to merge their coverage data. Some other "quick" checks (like formatting, linting) were also moved to a separate job, which allows the tests to run even if there is a linting issue.

Refs:

dhaiducek
dhaiducek previously approved these changes Aug 12, 2024
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold if you want to address any of the comments

LGTM! This sure has come a long way from when it ran serially! I have a couple minor comments, but I think they're more musings than anything that should block the PR.

Don't forget to update the Prow branch protections also. 🙂

.github/workflows/kind.yml Show resolved Hide resolved
.github/workflows/kind.yml Outdated Show resolved Hide resolved
.github/workflows/kind.yml Outdated Show resolved Hide resolved
The hosted mode tests and the "regular" tests were running in series,
and each took about 20 minutes. Now they run in parallel in separate
jobs, with a new job to merge their coverage data. Some other "quick"
checks (like formatting, linting) were also moved to a separate job,
which allows the tests to run even if there is a linting issue.

Refs:
 - https://issues.redhat.com/browse/ACM-13032

Signed-off-by: Justin Kulikauskas <[email protected]>
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

Copy link

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JustinKuli
Copy link
Member Author

The oddly failing test gives a chance to confirm if re-running will work with this artifacts upload/download stuff, so I guess that's nice 😆

@openshift-merge-bot openshift-merge-bot bot merged commit 8b0aecf into open-cluster-management-io:main Aug 12, 2024
13 checks passed
@JustinKuli JustinKuli deleted the 13032-parallel-hosted-job branch August 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants