Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency logic considering dots in names #240

Merged

Conversation

dhaiducek
Copy link
Member

There was an assumption a dot in a name meant it contained the namespace. But this doesn't make sense if the namespace is also provided.

ref: https://issues.redhat.com/browse/ACM-14241

There was an assumption a dot in a name meant it
contained the namespace. But this doesn't make
sense if the namespace is also provided.

ref: https://issues.redhat.com/browse/ACM-14241
Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek
Copy link
Member Author

Oh hello old friend:

• [FAILED] [32.125 seconds]
Test Hub Template Encryption Test that a secret can be securely copied to managed clusters [It] Should be compliant after enforcing it
/home/runner/work/governance-policy-propagator/governance-policy-propagator/framework/test/e2e/hub_templates_encryption_test.go:62

  [FAILED] Timed out after 30.001s.
  Expected
      <v1.ComplianceState>: NonCompliant
  to equal
      <v1.ComplianceState>: Compliant
  In [It] at: /home/runner/work/governance-policy-propagator/governance-policy-propagator/framework/test/e2e/hub_templates_encryption_test.go:64 @ 09/16/24 20:33:38.309

ref: https://github.com/open-cluster-management-io/governance-policy-propagator/actions/runs/10891467745/job/30222428880?pr=240

@openshift-ci openshift-ci bot added the lgtm label Sep 17, 2024
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e5ef033 into open-cluster-management-io:main Sep 17, 2024
13 checks passed
@dhaiducek dhaiducek deleted the 14241-dot-dep branch September 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants