reply review

Signed-off-by: myan <[email protected]>
open-cluster-management-io · Sep 12, 2024 · 67112a9 · 67112a9
1 parent 8c99358
commit 67112a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/pkg/cloudevents/generic/options/mqtt/agentoptions.go b/pkg/cloudevents/generic/options/mqtt/agentoptions.go
@@ -96,7 +96,7 @@ func (o *mqttAgentOptions) Protocol(ctx context.Context) (options.CloudEventsPro
 
 	// receiving status resync events from all sources
 	if len(o.Topics.SourceBroadcast) != 0 {
-		subscribe.Subscriptions = appendSubscriptions(subscribe.Subscriptions, paho.SubscribeOptions{
+		subscribe.Subscriptions = append(subscribe.Subscriptions, paho.SubscribeOptions{
 			Topic: o.Topics.SourceBroadcast,
 			QoS:   byte(o.SubQoS),
 		})
@@ -116,16 +116,3 @@ func (o *mqttAgentOptions) Protocol(ctx context.Context) (options.CloudEventsPro
 func (o *mqttAgentOptions) ErrorChan() <-chan error {
 	return o.errorChan
 }
-
-func appendSubscriptions(options []paho.SubscribeOptions, option paho.SubscribeOptions) []paho.SubscribeOptions {
-	exist := false
-	for _, sub := range options {
-		if sub.Topic == option.Topic {
-			exist = true
-		}
-	}
-	if !exist {
-		options = append(options, option)
-	}
-	return options
-}
diff --git a/pkg/cloudevents/generic/options/mqtt/sourceoptions.go b/pkg/cloudevents/generic/options/mqtt/sourceoptions.go
@@ -91,7 +91,7 @@ func (o *mqttSourceOptions) Protocol(ctx context.Context) (options.CloudEventsPr
 
 	if len(o.Topics.AgentBroadcast) != 0 {
 		// receiving spec resync events from all agents
-		subscribe.Subscriptions = appendSubscriptions(subscribe.Subscriptions, paho.SubscribeOptions{
+		subscribe.Subscriptions = append(subscribe.Subscriptions, paho.SubscribeOptions{
 			Topic: o.Topics.AgentBroadcast,
 			QoS:   byte(o.SubQoS),
 		})