Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to push component archive to insecure registry after bumping ocm to v0.16.0 #971

Open
Tracked by #1064
nesmabadr opened this issue Oct 17, 2024 · 8 comments
Assignees
Labels

Comments

@nesmabadr
Copy link

nesmabadr commented Oct 17, 2024

What happened:

When I try to push component archive to an insecure registry, I get an error saying "could not push component version: failed to finish component transfer: module version: creating target version: Head https url: http: server gave HTTP response to HTTPS client:"

What you expected to happen:
The component archive should have been pushed successfully to the insecure image

How to reproduce it (as minimally and precisely as possible):
Use the Golang function transfer.TransferVersion with an insecure registry (having an http prefix)

Anything else we need to know:

This is after the use of ORAs which always has the PlainHttp set to false regardless the registry is insecure or not.

Environment:
Golang package ocm.software/ocm v0.16.0

@nesmabadr nesmabadr added the kind/bug Bug label Oct 17, 2024
@github-actions github-actions bot added the area/ipcei IPCEI-CIS label Oct 17, 2024
@morri-son
Copy link
Contributor

@Skarlso, can you please check this as this worked before introducing ORAS? #755 is asking for an own flag to easily enable insecure protocols, so related topic.

@Skarlso Skarlso self-assigned this Oct 17, 2024
@Skarlso
Copy link
Contributor

Skarlso commented Oct 17, 2024

#968 will also fix this issue now.

@morri-son
Copy link
Contributor

#972 just flew in :-)

@Skarlso
Copy link
Contributor

Skarlso commented Oct 18, 2024

@nesmabadr Can you test with the main branch please? :) I pushed the fix in.

@nesmabadr
Copy link
Author

@Skarlso it is now working, thanks a lot! When should this be released?

@Skarlso
Copy link
Contributor

Skarlso commented Oct 18, 2024

Nice thanks for checking.

I don't know unfortunately. Maybe today but if not then next week. I'll ask the team.

@Skarlso
Copy link
Contributor

Skarlso commented Oct 18, 2024

Hey, just created a new release v0.16.1. Once this finishes https://github.com/open-component-model/ocm/actions/runs/11404619423 you can use the new version that contains this patch.

@Skarlso
Copy link
Contributor

Skarlso commented Oct 24, 2024

We've reverted the ORAS changes. We'll release a new version that will contain the old docker code, so this should no longer be a problem.

@hilmarf hilmarf mentioned this issue Nov 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔍 Review
Development

No branches or pull requests

3 participants