refactor: improve code performance

open-craft · Sep 4, 2024 · 438f900 · 438f900
1 parent 176f801
commit 438f900
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/openedx/core/djangoapps/discussions/serializers.py b/openedx/core/djangoapps/discussions/serializers.py
@@ -265,14 +265,6 @@ def update(self, instance: DiscussionsConfiguration, validated_data: dict) -> Di
             course_overview_id=instance.context_key,
             type='discussion'
         ).update(is_hidden=not instance.enabled)
-        # do the same for the modulestore representation
-        store = modulestore()
-        course = store.get_course(instance.context_key)
-        for tab in course.tabs:
-            if tab.tab_id == 'discussion':
-                tab.is_hidden = not instance.enabled
-                store.update_item(course, self.context['user_id'])
-                break
         update_discussions_settings_from_course_task.delay(str(instance.context_key))
         return instance