Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a feature flag to disable dates tab for all courses #654

Conversation

Cup0fCoffee
Copy link
Member

@Cup0fCoffee Cup0fCoffee commented Apr 15, 2024

⚠️ This PR is based on #655. It doesn't depend on it. If the mentioned PR doesn't end up being merged, rebase this PR onto target branch to omit commits.

Description

This is backport of openedx#34511.

References

BB-8721

Upstream PR

@Cup0fCoffee Cup0fCoffee force-pushed the maxim/bb-8271-hiding-dates-tab-for-all-courses-quince-backport branch 3 times, most recently from b03cd15 to 626202b Compare April 16, 2024 08:37
@Cup0fCoffee Cup0fCoffee force-pushed the maxim/bb-8271-hiding-dates-tab-for-all-courses-quince-backport branch from 626202b to 0e8e9f5 Compare April 22, 2024 12:15
Copy link
Member

@ArturGaspar ArturGaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: setting the feature flag hides the dates tab when it is otherwise shown
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository. - N/A

@Cup0fCoffee Cup0fCoffee merged commit 96efd39 into opencraft-release/quince.1 Apr 25, 2024
42 checks passed
@Cup0fCoffee Cup0fCoffee deleted the maxim/bb-8271-hiding-dates-tab-for-all-courses-quince-backport branch April 25, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants