Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unhide discussion tab when enabling it #677

Merged
merged 4 commits into from
Sep 4, 2024
Merged

fix: unhide discussion tab when enabling it #677

merged 4 commits into from
Sep 4, 2024

Conversation

viadanna
Copy link
Member

@viadanna viadanna commented Sep 2, 2024 •
edited
Loading

Description

Update the is_hidden property in the modulestore to properly store the visibility of the discussions tab.

Supporting information

  • BB-9120

Testing instructions

  1. Create a course in a Palm devstack/sandbox.
  2. Set the discussion tab to hidden.
  3. Export the course.
  4. Import the course in a Redwood devstack/sandbox.
  5. Create a Course Update
  6. Verify the discussion tab disappears in the LMS.
  7. Apply this change to the devstack/sandbox.
  8. Enable the discussions in Studio Pages & Resources.
  9. Create a Course Update.
  10. Verify the discussion tab does not disappear this time.

Deadline

ASAP

@viadanna viadanna self-assigned this Sep 2, 2024
@viadanna viadanna changed the title Draft: fix: unhide discussion tab when enabling it fix: unhide discussion tab when enabling it Sep 3, 2024
xitij2000
xitij2000 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

  • I tested this: tested by @viadanna
  • I read through the code

@viadanna viadanna merged commit 11ddc19 into opencraft-release/redwood.1 Sep 4, 2024
77 checks passed
@viadanna viadanna deleted the viadanna/redwood/show-discussion-tab branch September 4, 2024 19:39
viadanna added a commit that referenced this pull request Sep 4, 2024
@viadanna
fix: unhide discussion tab when enabling it (#677)
8c4abae
@viadanna viadanna mentioned this pull request Sep 4, 2024
Open
viadanna added a commit that referenced this pull request Sep 4, 2024
@viadanna
fix: unhide discussion tab when enabling it (#677)
80e27f6
@viadanna viadanna mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xitij2000 xitij2000 xitij2000 approved these changes

Assignees

@viadanna viadanna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viadanna @xitij2000