-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update collections crud rest api #683
Update collections crud rest api #683
Conversation
ChrisChV
commented
Sep 10, 2024
•
edited
Loading
edited
- Update description as optional: 3c79543
- Update create collection API to auto-generate key: 8118b77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @ChrisChV!
I think it is missing the handler to update the search index after creating a collection. If you feel this should be done in another task, make sure that you create one for it (I didn't find any).
- I tested this using the instructions from feat: Create collection Modal [FC-0062] openedx/frontend-app-authoring#1259
- I read through the code
-
I checked for accessibility issues -
Includes documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @ChrisChV Thank you for proposing this solution. I'm ok with this change -- since we added Collection.key late in the game, there's no explicit requirement to let users enter their own key, and we're under some time pressure here.
- I tested this on my tutor devstack with Store Collection metadata + component count in meilisearch openedx/frontend-app-authoring#1260
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
48a1667
into
yusuf-musleh/collections-crud-rest-api
I created this ticket for that: openedx/frontend-app-authoring#1260 Trying to get it done under FAL-3817, but will see. |
* Update description as optional in ContentLibraryCollectionUpdateSerializer * Create collection Rest API to auto-generate key