Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB-9078] Styling fix #68

Open
wants to merge 3 commits into
base: asu-moe/redwood-css
Choose a base branch
from
Open

Conversation

pkulkark
Copy link
Member

This PR fixes the styling for long titles that should be truncated.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (acbd7fa) to head (95cc92b).
Report is 5 commits behind head on asu-moe/redwood-css.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #68      +/-   ##
=======================================================
+ Coverage                92.54%   92.60%   +0.06%     
=======================================================
  Files                      706      706              
  Lines                    12515    12524       +9     
  Branches                  2728     2701      -27     
=======================================================
+ Hits                     11582    11598      +16     
+ Misses                     898      891       -7     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -5,7 +5,7 @@
.item-card-header__title-btn {
justify-content: flex-start;
padding: 0;
width: fit-content;
width: 100%;
Copy link
Member

@kaustavb12 kaustavb12 Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkulkark

Although this solves the issue at hand, it does make the edit button as well as the Draft (Unpub..) tag look quite odd and squished

Before change:
image

After change:
image

I would suggest the following changes which seems to solve our problem without affecting other elements:

Suggested change
width: 100%;
width: fit-content;
max-width: 62%;

What do you think ? cc. @0x29a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaustavb12 I'm not sure that's going to work. With width: fit-content the truncated line gets wrapped which was the original issue. Maybe we can play around with max-width while keeping width: 100% but it feels like that's still going to throw off the styling one way or the other. The oc instance studio seems to be down at the moment. Will test it once it's up and running and update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants