roles: Fill content #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
added
topic/roles
razvand
force-pushed
the
razvand/roles
branch
from
aa5707b to
cadab3b
Compare
teodutu
requested changes
Dec 28, 2023
There was a problem hiding this comment.
- All images have transparent backgrounds. This sucks if they're viewed in dark mode. Add a white rectangle behind each of them in
draw.ioto force a white background. - Remember to change all existing
README.mdfiles toread.md. Otherwise, the links to them won't work.
razvand
force-pushed
the
razvand/roles
branch
2 times, most recently
from
fde9b90 to
952442a
Compare
@teodutu , there are no I added white background to SVG files. |
Fill contents of "Roles" chapter / section. Signed-off-by: Razvan Deaconescu <[email protected]>
razvand
force-pushed
the
razvand/roles
branch
from
952442a to
e8432bf
Compare
teodutu
added a commit
to teodutu/methodology
that referenced
this pull request
Dec 28, 2023
PR open-education-hub#52 introduced new media files for the "Roles" chapter without adding that folder to the `config.yaml` file, causing a builder error. This PR addresses this issue by adding the path to the `media/` folder to said config file. Signed-off-by: Teodor Dutu <[email protected]>
2 tasks
razvand
pushed a commit
that referenced
this pull request
Dec 28, 2023
PR #52 introduced new media files for the "Roles" chapter without adding that folder to the `config.yaml` file, causing a builder error. This PR addresses this issue by adding the path to the `media/` folder to said config file. Signed-off-by: Teodor Dutu <[email protected]>
razvand
pushed a commit
to razvand/methodology
that referenced
this pull request
Dec 28, 2023
PR open-education-hub#52 introduced new media files for the "Roles" chapter without adding that folder to the `config.yaml` file, causing a builder error. This PR addresses this issue by adding the path to the `media/` folder to said config file. Signed-off-by: Teodor Dutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
Fill contents of "Roles" chapter / section.