-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update introduction files #60
Merged
teodutu
merged 3 commits into
open-education-hub:main
from
razvand:razvand/update-intro-md-files
Dec 28, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
# Contributing to Open Education Hub Methodology | ||
|
||
These are recommendations when contributing to the contents of the Open Education Hub methodology. | ||
They consider contributions to both actual content (mostly Markdown) and support code made via Git. | ||
|
||
## First Steps | ||
|
||
Some good first steps and best practices when using Git are explained here: | ||
|
||
* the Git Immersion tutorial: <https://gitimmersion.com/> | ||
* the Atlassian tutorial: <https://www.atlassian.com/git/tutorials/learn-git-with-bitbucket-cloud> | ||
* this blog post on the `ROSEdu Techblog`: <https://techblog.rosedu.org/git-good-practices.html> | ||
|
||
## Language | ||
|
||
All of our content is developed in English. | ||
This means we use English for content, support code, commit messages, pull requests, issues, comments, everything. | ||
|
||
## Content Writing Style | ||
|
||
This section addresses the development of session content and other Markdown files. | ||
|
||
Write each sentence on a new line. | ||
This way, changing one sentence only affects one line in the source code. | ||
|
||
Use the **first person plural** when writing documentation and tutorials. | ||
Use phrases like "we run the command / app", "we look at the source code", "we find the flag". | ||
|
||
Use the second person for challenges and other individual activities. | ||
Use phrases like "find the flag", "run this command", "download the tool". | ||
|
||
## Images | ||
|
||
Use [draw.io](https://app.diagrams.net/) to create diagrams. | ||
If using external images / diagram, make sure they use a CC BY-SA license and give credits (mention author and / or add link to the image source). | ||
|
||
## Slides | ||
|
||
Slides are to be written in Markdown, using [`reveal-md`](https://github.com/webpro/reveal-md), itself based on [`reveal-js`](https://revealjs.com/). | ||
Use `reveal-md` and `reveal-js` specifics to split information in slides. | ||
Aim to make slides attractive, sleek and simple to follow. | ||
|
||
Images and diagrams would ideally be animated on slides. | ||
Aim to use `reveal.js` features to animate drawing of diagrams. | ||
|
||
If `reveal.js` drawing is difficult, use [draw.io](https://app.diagrams.net/) to create diagrams. | ||
Ideally you would "animate" those diagrams by creating multiple incremental versions of the diagram and adding each to a slide; | ||
when browsing slides pieces of these diagrams will "appear" and complete the final image, rendering an animation-like effect. | ||
|
||
## Issues | ||
|
||
When opening an issue, please clearly state the problem. | ||
Make sure it's reproducible. | ||
Add images if required. | ||
Also, if relevant, detail the environment you used (OS, software versions). | ||
Ideally, if the issue is something you could fix, open a pull request with the fix. | ||
|
||
## Discussions | ||
|
||
Use GitHub discussions for bringing up ideas on content, new chapters, new sections. | ||
Provide support to others asking questions and take part in suggestions brought by others. | ||
Please be civil when taking part in discussions. | ||
|
||
## Pull Requests | ||
|
||
For pull requests, please follow the [GitHub flow](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork): create a fork of the repository, create your own branch, do commits, push changes to your branch, do a pull request (PR). | ||
The destination branch of pull requests is the default `master` branch. | ||
|
||
Make sure each commit corresponds to **one** code / content change only. | ||
If there are multiple commits belonging to a given change, please squash the commits. | ||
|
||
Also make sure one pull request covers only **one** topic. | ||
|
||
### Commits | ||
|
||
Before making a commit, configure your name and email locally using: | ||
|
||
```bash | ||
git config --global user.name "Your Name" | ||
git config --global user.email "[email protected]" | ||
``` | ||
|
||
Then make sure the email you've just configured corresponds to the one you have [set on GitHub](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account). | ||
|
||
After this, make your changes, `git add` them and then commit them using `git commit -s`. | ||
Always sign your commits using the `-s` / `--signoff` arguments to `git commit`. | ||
This will add the following line at the end of the commit message: | ||
|
||
```text | ||
Signed-off-by: Your Name <[email protected]> | ||
``` | ||
|
||
Notice that the details above are the name and email that you configured earlier. | ||
|
||
Now the `git commit` command will open your default editor and ask you to write a commit message. | ||
Prefix each commit message name with the chapter and content type it belongs to, e.g. `use-deliver/reading`, `curate-maintain/media`. | ||
Following the prefix, write a short and expressive title on the first line. | ||
Use commit messages with verbs at imperative mood: "Add README", "Update contents", "Introduce feature". | ||
|
||
Leave an empty line, then add a relevant description of the changes made in that commit. | ||
This description should include why that change is needed (fixes a bug, improves something that was inefficient, etc.). | ||
Wrap the lines of this description to 75 characters. | ||
How a good commit message should look like: <https://cbea.ms/git-commit/> | ||
Below is an example of a good commit message: | ||
|
||
```text | ||
template-chapter/drills: Fix Makefile `CFLAGS` error | ||
|
||
`CFLAGS` was incorrectly set to optimise the code to the `-O3` level. This | ||
caused the function `vulnerable_func()` to be inlined into the caller | ||
`main()`, making it impossible to overwrite `main()`'s return address with | ||
that of `vulnerable_func()`. This commit fixes the issue by forcing the | ||
compiler to not optimise the code by replacing `-O3` with `-O0` in `CFLAGS` | ||
|
||
Signed-off-by: Your Name <[email protected]> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Reviewing Contributions | ||
|
||
These are recommendations when reviewing contributions to the Open Education Hub Methodology repository. | ||
Contributions will mostly take the form of GitHub pull requests (PRs); | ||
issues and discussions are expected as well. | ||
|
||
When reviewing contributions, please be civil and welcoming towards contributors. | ||
Contributions may not be in the best shape initially, but we appreciate time and effort spent in doing this. | ||
|
||
Make sure contributions follow the [contribution guide](CONTRIBUTING.md): proper formatting, proper wording, proper styling. | ||
See if the contributions fit into the scope of the repository and solve a problem or add value to it. | ||
|
||
If a contribution is OK, please approve it. | ||
In case of a reviewed and approved PR, the assignee will then `Rebase and merge` the PR. | ||
|
||
If a contribution needs work, please make the appropriate comments. | ||
For a PR use discussion comments, or comments on the code / text, or directly [suggest changes](https://thenextweb.com/news/github-launches-suggested-changes-to-make-it-easier-to-collaborate-within-pull-requests). |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you name these 2 "license"? Or is there a reason why they muat be named "copying.md"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is because we host both licenses in the same file. That's why I prefer
COPYING.md
. Both are handled by GitHub.