Add initial i18n support #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
requested changes
Nov 30, 2023
There was a problem hiding this comment.
@VladNastase changing the language to RO and then changing it again will break the url. If trying to change back to English the url will still be ..../ro, if trying to change to RO again the url will be ...../ro/ro. Basically once you change to RO the ro/ in the url will never disappear.
Also see the conflicts with the main branch.
|
I cannot reproduce the issue with the repeated language changes. Can you provide more details about the way you are serving the website? I am using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for internationalisation and localisation.
The files that need to be translated to romanian are under
website/i18n/ro/. Currently, they are a copy of the current ones, in english.