feat!: add new sync proto, rm old sync proto (#99)

Signed-off-by: Todd Baert <[email protected]>
open-feature · Feb 6, 2024 · fed2389 · fed2389
1 parent 9698f93
commit fed2389
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 8 deletions.
diff --git a/sync/README.md b/sync/README.md
@@ -50,12 +50,17 @@ Test the sync from the command line with [grpcurl](https://github.com/fullstoryd
 
 ```shell
 # request all flags
-grpcurl -import-path '/path/to/proto/dir' -proto sync.proto -plaintext localhost:9090 sync.v1.FlagSyncService/FetchAllFlags
+grpcurl -import-path '/path/to/proto/dir' -proto sync.proto -plaintext localhost:9090 flagd.sync.v1.FlagSyncService/FetchAllFlags
 ```
 
 ```shell
 # open a stream for getting flag changes
-grpcurl -import-path '/path/to/proto/dir' -proto sync.proto -plaintext localhost:9090 sync.v1.FlagSyncService/SyncFlags
+grpcurl -import-path '/path/to/proto/dir' -proto sync.proto -plaintext localhost:9090 flagd.sync.v1.FlagSyncService/SyncFlags
+```
+
+```shell
+# get metadata
+grpcurl -import-path '/path/to/proto/dir' -proto sync.proto -plaintext localhost:9090 flagd.sync.v1.FlagSyncService/GetMetadata
 ```
 
 ### Generate certificates ? 

diff --git a/sync/pkg/server.go b/sync/pkg/server.go
@@ -1,16 +1,17 @@
 package sync
 
 import (
-	"buf.build/gen/go/open-feature/flagd/grpc/go/sync/v1/syncv1grpc"
-	v1 "buf.build/gen/go/open-feature/flagd/protocolbuffers/go/sync/v1"
 	"context"
 	"crypto/tls"
 	"fmt"
-	"google.golang.org/grpc"
-	"google.golang.org/grpc/credentials"
 	"log"
 	"net"
 	"sync"
+
+	"buf.build/gen/go/open-feature/flagd/grpc/go/flagd/sync/v1/syncv1grpc"
+	v1 "buf.build/gen/go/open-feature/flagd/protocolbuffers/go/flagd/sync/v1"
+	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials"
 )
 
 type Server struct {
@@ -92,7 +93,6 @@ func (s *SyncImpl) SyncFlags(req *v1.SyncFlagsRequest, stream syncv1grpc.FlagSyn
 	// initial read
 	err := stream.Send(&v1.SyncFlagsResponse{
 		FlagConfiguration: string(s.fw.getCurrentData()),
-		State:             v1.SyncState_SYNC_STATE_ALL,
 	})
 	if err != nil {
 		log.Printf("Error sending initial stream: %v\n", err)
@@ -108,7 +108,6 @@ func (s *SyncImpl) SyncFlags(req *v1.SyncFlagsRequest, stream syncv1grpc.FlagSyn
 		case data := <-listener:
 			err = stream.Send(&v1.SyncFlagsResponse{
 				FlagConfiguration: string(data),
-				State:             v1.SyncState_SYNC_STATE_ALL,
 			})
 			if err != nil {
 				// this is probably a close
@@ -131,3 +130,14 @@ func (s *SyncImpl) FetchAllFlags(context.Context, *v1.FetchAllFlagsRequest) (*v1
 		FlagConfiguration: string(marshalled),
 	}, nil
 }
+
+func (s *SyncImpl) GetMetadata(context.Context, *v1.GetMetadataRequest) (*v1.GetMetadataResponse, error) {
+	return &v1.GetMetadataResponse{
+		Metadata: []*v1.KeyValue{
+			{
+				Key:   "paths",
+				Value: fmt.Sprintf("%v", s.fw.paths),
+			},
+		},
+	}, nil
+}