feat: add certificates for ssl test and an ssl test image #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
links to #159 |
|
tested with java, worked |
aepfli
requested review from
beeme1mr,
chrfwow,
warber,
alexandraoberaigner and
guidobrei
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/ssl-image
branch
from
01ee717 to
742ad5f
Compare
|
the only thing which we might want to add, is also a gherkin file for testing, but on the other hand, we could reuse the evaluation.feature with the basic testing flags |
beeme1mr
reviewed
Dec 17, 2024
| @@ -0,0 +1,52 @@ | |||
| -----BEGIN PRIVATE KEY----- | |||
There was a problem hiding this comment.
Should we make this a GitHub secret? I know it's just for testing but I'm afraid scanners might pick this up and open issues in the repo.
There was a problem hiding this comment.
Well we could theoretically - I would for now leave it as is, and optimize if needed
There was a problem hiding this comment.
Ya I would rather just ignore it in whatever tools flag it.
beeme1mr
approved these changes
Dec 17, 2024
|
👏 👏 👏 👏 Can't wait to have this implemented in various places. I'd be happy to help. |
toddbaert
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another image protected via an SSL certificate with a custom CA.
If a key is used, the password is
flagdin the creation process.dockerfile improvements
Instead of having now two different dockerfiles, copying the files, and executing the script, i reduced one layer, by depending on the testbed image and only changing the entry point
testing
first run the docker container
docker run --rm -p 8013:8013 flagd-testbed-sslcurl -v --cacert ./custom-root-cert.crt https://localhost:8013/healthshould run in to 404curl -v https://localhost:8013/healthshould run in to a cert errorcloses #159