Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug][flagd-rpc] We can not retrieve object flags due to a type mismatch error #102

Closed
aepfli opened this issue Nov 14, 2024 · 2 comments · Fixed by #103
Closed

[bug][flagd-rpc] We can not retrieve object flags due to a type mismatch error #102

aepfli opened this issue Nov 14, 2024 · 2 comments · Fixed by #103

Comments

@aepfli
Copy link
Member

aepfli commented Nov 14, 2024

I implemented #101 and could not correctly test object flags with our gherkin suite, as I am constantly getting a type mismatch.

The type we're getting from the resolver does not match the expected type in Python for object flags. I checked the provider's response, and everything was returned as expected. But the struct never seems to be correctly translated into the Python object.
aepfli added a commit to open-feature-forking/python-sdk-contrib that referenced this issue Nov 17, 2024
@aepfli
fix(flagd): object resolution for RPC and Object types (open-feature#102
5c51fe4 
)

Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli mentioned this issue Nov 17, 2024
Closed
@aepfli
Copy link
Member Author

aepfli commented Nov 17, 2024

i created a fix for this bug, but it relies on #101

@aepfli aepfli changed the title [bug][flagd-remote] We can not retrieve object flags due to a type mismatch error [bug][flagd-rpc] We can not retrieve object flags due to a type mismatch error Nov 17, 2024
@aepfli
Copy link
Member Author

aepfli commented Nov 17, 2024

this is also most likely happening in the in-process approach, but i think we should wait for #84 before we try to tackle this

@aepfli aepfli mentioned this issue Nov 17, 2024
Merged
aepfli added a commit to open-feature-forking/python-sdk-contrib that referenced this issue Nov 18, 2024
@aepfli
fix(flagd): object resolution for RPC and Object types (open-feature#102
15b8632 
)

Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli mentioned this issue Nov 18, 2024
Merged
aepfli added a commit to open-feature-forking/python-sdk-contrib that referenced this issue Nov 18, 2024
@aepfli
fix(flagd): object resolution for RPC and Object types (open-feature#102
6dc03d0 
)

Signed-off-by: Simon Schrottner <[email protected]>
aepfli added a commit to open-feature-forking/python-sdk-contrib that referenced this issue Nov 18, 2024
@aepfli
fix(flagd): object resolution for RPC and Object types (open-feature#102
32c74b1 
)

Signed-off-by: Simon Schrottner <[email protected]>
aepfli added a commit to open-feature-forking/python-sdk-contrib that referenced this issue Nov 18, 2024
@aepfli
fix(flagd): object resolution for RPC and Object types (open-feature#102
d0c5784 
)

Signed-off-by: Simon Schrottner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(flagd): fix object resolution open-feature-forking/python-sdk-contrib
1 participant
@aepfli