Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flagd): fix object resolution #103

Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Nov 18, 2024

closes: #102

blockedby: #101 - changes included from this PR - hence i suggest to wait with a review till this one is merged

@aepfli aepfli changed the title bug(flagd): fix object resolution fix(flagd): fix object resolution Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (d8e10c7) to head (d0c5784).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   90.55%   94.24%   +3.68%     
==========================================
  Files           8       12       +4     
  Lines         180      469     +289     
==========================================
+ Hits          163      442     +279     
- Misses         17       27      +10     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@aepfli aepfli force-pushed the bug/102-fix_object_resolution branch 2 times, most recently from 6dc03d0 to 32c74b1 Compare November 18, 2024 19:36
@aepfli aepfli force-pushed the bug/102-fix_object_resolution branch from 32c74b1 to d0c5784 Compare November 18, 2024 19:37
@aepfli aepfli marked this pull request as ready for review November 18, 2024 19:37
@aepfli aepfli requested a review from a team as a code owner November 18, 2024 19:37
Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🍻

@toddbaert toddbaert merged commit ca76802 into open-feature:main Nov 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug][flagd-rpc] We can not retrieve object flags due to a type mismatch error
5 participants