Backport PDF when submissions need to be cosigned #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cosign status A submission requiring cosigning is still in a waiting state before it will be sent to a registration backend. The language used in the PDF now makes this clear, which should also avoid legal implications associated with the displayed 'completion' timestamp. (cherry picked from commit 8b6ecf0)
sergei-maertens
force-pushed
the
backport/dh-cosign-pdf-text
branch
from
09403fd to
8cf6f6e
Compare
|
@vaszig this needs to go in the 2.8.2 patch release :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/2.8.x #4846 +/- ##
================================================
- Coverage 96.58% 96.56% -0.02%
================================================
Files 746 746
Lines 25247 25256 +9
Branches 3325 3328 +3
================================================
+ Hits 24384 24389 +5
- Misses 601 603 +2
- Partials 262 264 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Closed
|
I'm ignoring the missing coverage here - tests and coverage are provided in the PR to the master branch |
vaszig
approved these changes
Nov 22, 2024
|
Why do we need a backport for 2.8.2 and not for 2.7.10? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by DH as they're worried about legal implications of the language used currently.
Taken from #4320 / #4838