Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-658: Update the ingestion schedular with new design #17990

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Sep 25, 2024

Fixes #17209
Fixes #18188
Fixes #18019

I worked on the following:

Screen.Recording.2024-10-17.at.5.13.58.PM.mov
  • Update the scheduler according to the new mocks

  • Update the new scheduler in all the places

  • Make the Daily the default schedule except for the Data Insights Report application which will have Week as the default schedule

  • Add a validation check for the custom cron expression to prevent cron from setting intervals that are more frequent than hourly.

  • Fix the issue where the set schedule was not reflecting on the edit ingestion page.

  • Fix the ingestion pipeline search returning pipelines from other services as well.

Before:

Screen.Recording.2024-10-17.at.5.51.22.PM.mov

After:

Screen.Recording.2024-10-17.at.5.51.49.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues e2e This will trigger e2e test workflows labels Sep 25, 2024
@aniketkatkar97 aniketkatkar97 self-assigned this Sep 25, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 25, 2024
chirag-madlani
chirag-madlani previously approved these changes Oct 17, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
2 participants