[ER Diagrams] Add ER diagram APIs and sample data #18021
Conversation
github-actions
bot
added
Ingestion
safe to test
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Jest test CoverageUI tests summary
|
| if (depth <= 0) { | ||
| return; | ||
| } | ||
| es.org.elasticsearch.action.search.SearchRequest searchRequest = |
There was a problem hiding this comment.
we need to put full package names here
| String direction, | ||
| boolean deleted) | ||
| throws IOException { | ||
| if (depth <= 0) { |
There was a problem hiding this comment.
how can be depth be below 0 here? we should throw an error not return
There was a problem hiding this comment.
This is a function that will be called recursively. The depth is there for handling that
E.g by default depth with start at 3 and then with each recursion it'll get decremented unless it reaches 0
openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/SearchIndex.java
Outdated
Show resolved
Hide resolved
| if (depth <= 0) { | ||
| return; | ||
| } | ||
| os.org.opensearch.action.search.SearchRequest searchRequest = |
There was a problem hiding this comment.
avoid full package names like this here
1 similar comment
1 similar comment
1 similar comment
OnkarVO7
changed the title
1 similar comment
|
|
Describe your changes:
Add ER diagram APIs and sample data
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>