Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix rbac for multiple rules #18057

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Minor: Fix rbac for multiple rules #18057

merged 6 commits into from
Oct 18, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Oct 1, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner October 1, 2024 06:32
@harshach harshach changed the title Fix rbac for multiple rules Minor: Fix rbac for multiple rules Oct 1, 2024
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Oct 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@harshach harshach merged commit c78cda6 into main Oct 18, 2024
14 of 19 checks passed
@harshach harshach deleted the fix_rbac_for_multiple_rules branch October 18, 2024 02:15
harshach added a commit that referenced this pull request Oct 19, 2024
@harshach @mohityadav766
Minor: Fix rbac for multiple rules (#18057)
aeacfeb 
* Minor: Search RBAC, fix condition evaluation for single policy multiple rules

* Minor: Search RBAC, fix condition evaluation for single policy multiple rules

* add test for complex policies

* Add viewAll policy to organization

---------

Co-authored-by: Mohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshach @mohityadav766