Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: add supportsDataDiff flag #18205

Merged
merged 6 commits into from
Oct 16, 2024
Merged

MINOR: add supportsDataDiff flag #18205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7921c0b
feat: add supportsDataDiff flag
sushi30 Oct 10, 2024
8315d24
fixed mysql migration
sushi30 Oct 10, 2024
54cd092
Merge branch 'main' into add-support-table-diff-flag
sushi30 Oct 11, 2024
116d6de
fixed conflicts
sushi30 Oct 11, 2024
e6f0d25
Merge branch 'main' into add-support-table-diff-flag
sushi30 Oct 12, 2024
2b6be96
Merge branch 'main' into add-support-table-diff-flag
sushi30 Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bootstrap/sql/migrations/native/1.6.0/mysql/postDataMigrationSQLScript.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,9 @@ SET json = JSON_REMOVE(json, '$.testCaseResult');
UPDATE installed_apps SET json = JSON_SET(json, '$.supportsInterrupt', true) where name = 'SearchIndexingApplication';
UPDATE apps_marketplace SET json = JSON_SET(json, '$.supportsInterrupt', true) where name = 'SearchIndexingApplication';

ALTER TABLE apps_extension_time_series ADD COLUMN appName VARCHAR(256) GENERATED ALWAYS AS (json ->> '$.appName') STORED NOT NULL;
ALTER TABLE apps_extension_time_series ADD COLUMN appName VARCHAR(256) GENERATED ALWAYS AS (json ->> '$.appName') STORED NOT NULL;

-- Add supportsDataDiff for Athena, BigQuery, Mssql, Mysql, Oracle, Postgres, Redshift, SapHana, Snowflake, Trino
UPDATE dbservice_entity
SET json = JSON_SET(json, '$.connection.config.supportsDataDiff', 'true')
WHERE serviceType IN ('Athena','BigQuery','Mssql','Mysql','Oracle','Postgres','Redshift','SapHana','Snowflake','Trino');
7 changes: 6 additions & 1 deletion bootstrap/sql/migrations/native/1.6.0/postgres/postDataMigrationSQLScript.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,9 @@ SET json = jsonb_set(
)
where name = 'SearchIndexingApplication';

ALTER TABLE apps_extension_time_series ADD COLUMN appName VARCHAR(256) GENERATED ALWAYS AS (json ->> 'appName') STORED NOT NULL;
ALTER TABLE apps_extension_time_series ADD COLUMN appName VARCHAR(256) GENERATED ALWAYS AS (json ->> 'appName') STORED NOT NULL;

-- Add supportsDataDiff for Athena, BigQuery, Mssql, Mysql, Oracle, Postgres, Redshift, SapHana, Snowflake, Trino
UPDATE dbservice_entity
SET json = jsonb_set(json::jsonb, '{connection,config,supportsDataDiff}', 'true'::jsonb)
WHERE serviceType IN ('Athena','BigQuery','Mssql','Mysql','Oracle','Postgres','Redshift','SapHana','Snowflake','Trino');
5 changes: 5 additions & 0 deletions ...-spec/src/main/resources/json/schema/entity/services/connections/connectionBasicType.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@
"description": "Supports DBT Extraction.",
"type": "boolean",
"default": true
},
"supportsDataDiff": {
"description": "Supports the data diff data qualty specification.",
"type": "boolean",
"default": true
},
"dataStorageConfig": {
"description": "Storage config to store sample data",
Expand Down
4 changes: 4 additions & 0 deletions ...src/main/resources/json/schema/entity/services/connections/database/athenaConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@
"type": "boolean",
"default": true
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
},
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
Expand Down
4 changes: 4 additions & 0 deletions ...c/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
4 changes: 4 additions & 0 deletions .../src/main/resources/json/schema/entity/services/connections/database/mssqlConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@
"supportsQueryComment": {
"title": "Supports Query Comment",
"$ref": "../connectionBasicType.json#/definitions/supportsQueryComment"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
4 changes: 4 additions & 0 deletions .../src/main/resources/json/schema/entity/services/connections/database/mysqlConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
4 changes: 4 additions & 0 deletions ...src/main/resources/json/schema/entity/services/connections/database/oracleConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@
"title": "Supports Query Comment",
"$ref": "../connectionBasicType.json#/definitions/supportsQueryComment"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
},
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
Expand Down
4 changes: 4 additions & 0 deletions ...c/main/resources/json/schema/entity/services/connections/database/postgresConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
4 changes: 4 additions & 0 deletions ...c/main/resources/json/schema/entity/services/connections/database/redshiftConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
4 changes: 4 additions & 0 deletions ...rc/main/resources/json/schema/entity/services/connections/database/sapHanaConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
4 changes: 4 additions & 0 deletions .../main/resources/json/schema/entity/services/connections/database/snowflakeConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
4 changes: 4 additions & 0 deletions .../src/main/resources/json/schema/entity/services/connections/database/trinoConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@
"sampleDataStorageConfig": {
"title": "Storage Config for Sample Data",
"$ref": "../connectionBasicType.json#/definitions/sampleDataStorageConfig"
},
"supportsDataDiff": {
"title": "Supports Data Diff Extraction.",
"$ref": "../connectionBasicType.json#/definitions/supportsDataDiff"
}
},
"additionalProperties": false,
Expand Down
Loading