Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-1836: Table custom property enhancements #18239

Merged
merged 17 commits into from
Oct 15, 2024
Merged

GEN-1836: Table custom property enhancements #18239

merged 17 commits into from
Oct 15, 2024
+422 −393

Conversation

sonika-shah
Copy link
Contributor

@sonika-shah sonika-shah commented Oct 11, 2024 •
edited by Sachin-chaurasiya
Loading

Describe your changes:

Table custom property enhancements:

  • Removed rowCount field from tableConfig.json
  • Removed restriction on row limit
  • Added pagination on the UI side
  • Added icons for all the properties in the add property form select property field and type column in custom entity custom properties table view
Screen.Recording.2024-10-14.at.4.31.57.PM.mov
image image

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added tests around the new logic.

@sonika-shah sonika-shah added backend safe to test Add this label to run secure Github workflows on PRs labels Oct 11, 2024
@sonika-shah sonika-shah requested a review from a team as a code owner October 11, 2024 20:18
sushi30
sushi30 previously approved these changes Oct 14, 2024
View reviewed changes
chirag-madlani
chirag-madlani previously approved these changes Oct 14, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit 62ee79e into main Oct 15, 2024
24 of 27 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the table-cp-enhancements branch October 15, 2024 07:11
Sachin-chaurasiya pushed a commit that referenced this pull request Oct 15, 2024
@sonika-shah @Sachin-chaurasiya
GEN-1836: Table custom property enhancements (#18239)
dfb7a3c
harshach pushed a commit that referenced this pull request Oct 17, 2024
@sonika-shah @Sachin-chaurasiya @harshach
GEN-1836: Table custom property enhancements (#18239)
1cdcda1 
* Table custom property enhancements

* ui: remove rowCount

* minor style file changes

* minor change to show no data placeholder

* add icons for property types

* fix type filtering issue

* fix spacing issue for custom properties card

* refactor comments and style file

* fix test

* add playwright test for adding/updating table type property in entity

* add sesrchField for search property by name

---------

Co-authored-by: Sachin Chaurasiya <[email protected]>
harshach pushed a commit that referenced this pull request Oct 19, 2024
@sonika-shah @Sachin-chaurasiya @harshach
GEN-1836: Table custom property enhancements (#18239)
f5802e1 
* Table custom property enhancements

* ui: remove rowCount

* minor style file changes

* minor change to show no data placeholder

* add icons for property types

* fix type filtering issue

* fix spacing issue for custom properties card

* refactor comments and style file

* fix test

* add playwright test for adding/updating table type property in entity

* add sesrchField for search property by name

---------

Co-authored-by: Sachin Chaurasiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani left review comments

@sushi30 sushi30 sushi30 left review comments

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sonika-shah @harshach @chirag-madlani @sushi30 @ShaileshParmar11 @Sachin-chaurasiya