Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #18007: Disabled Classifications or Tags shouldn't be visible in UI #18242

Merged
merged 6 commits into from
Oct 19, 2024
Merged

Fix #18007: Disabled Classifications or Tags shouldn't be visible in UI #18242

merged 6 commits into from
Oct 19, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Oct 13, 2024 •
edited by Ashish8689
Loading

Describe your changes:

Fixes #18007

  • Disabled Classifications or Tags, should not be visible in search list
  • Added Playwright test from the UI
Screen.Recording.2024-10-14.at.4.18.23.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner October 13, 2024 05:54
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Oct 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.14% (37810/58950) 40.86% (15078/36900) 42.97% (4554/10599)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@harshach harshach merged commit 9bffbfc into main Oct 19, 2024
25 of 27 checks passed
@harshach harshach deleted the issue-18007 branch October 19, 2024 21:18
harshach added a commit that referenced this pull request Oct 19, 2024
@harshach @Ashish8689
Fix #18007: Disabled Classifications or Tags shouldn't be visible in …
fff3eea 
…UI (#18242)

* Fix #18007: Disabled Classifications or Tags shouldn't be visible in UI

* added playwright test for disabled tags should not be visible while search

* replace testing tag to new generated one to avoid flakyness

* added test for checking tags are re-enabling it from disabled state

* fix the playwright test for the wrong column selector

---------

Co-authored-by: Ashish Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled Classifications or Tags shouldn't be visible in UI
3 participants
@harshach @ShaileshParmar11 @Ashish8689