Minor : Fix exception in search due to exception in database.displayN… #18290
Conversation
…ame and databaseSchema.aggregation
sonika-shah
added
the
safe to test
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
1 similar comment
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
| AggregationBuilders.terms("database.name.keyword") | ||
| .field("database.name.keyword") | ||
| .size(MAX_AGGREGATE_SIZE)); | ||
| searchSourceBuilder.aggregation( | ||
| AggregationBuilders.terms("databaseSchema.name.keyword") | ||
| .field("databaseSchema.name.keyword") | ||
| .size(MAX_AGGREGATE_SIZE)); | ||
| return addAggregation(searchSourceBuilder); |
There was a problem hiding this comment.
Should we do the aggregation on the fullyQualifiedName? Using name I believe if we have service.database.schema and otherService.database.schema then they'll both get aggregated under the same if we use name I believe.
There was a problem hiding this comment.
hi @TeddyCr thanks for pointing your concern is valid, but for our usage we are not dependent
only on a single aggregation while getting result, we check the condition with other aggregations as well
There was a problem hiding this comment.
have tried to replicate the same scenario with same database and schema, seems to be working fine.
Also will be removing the support for aggregations on name.keyword, as in most scenario we are moving to show results based on displayName
| searchSourceBuilder.aggregation( | ||
| AggregationBuilders.terms("database.name.keyword") | ||
| .field("database.name.keyword") | ||
| .size(MAX_AGGREGATE_SIZE)); | ||
| searchSourceBuilder.aggregation( | ||
| AggregationBuilders.terms("databaseSchema.name.keyword") | ||
| .field("databaseSchema.name.keyword") | ||
| .size(MAX_AGGREGATE_SIZE)); | ||
| return addAggregation(searchSourceBuilder); |
There was a problem hiding this comment.
Same question here https://github.com/open-metadata/OpenMetadata/pull/18290/files#r1803006416
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Describe your changes:
Minor : Fix exception in search due to exception in database.displayName and databaseSchema.aggregation
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>