Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #17042 - Allow non admin/bot to read profiler global config #18292

Merged
merged 5 commits into from
Oct 17, 2024
Merged

FIX #17042 - Allow non admin/bot to read profiler global config #18292

merged 5 commits into from
Oct 17, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Oct 16, 2024

Describe your changes:

Fixes #17042

  • Introduce ViewProfilerGlobalConfig permission to allow non admin/bot to read global profiler config on ingestion when using their personal token -- ViewAll will allow reading this config. It is possible to add ViewAll and explicitly deny ViewProfilerGlobalConfig if one chooses to
  • fix customer properties package name from customproperties to customProperties

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner October 16, 2024 10:56
@notion-workspace Notion Workspace
Copy link

Enable reading global profiler settings not only by admins and bots

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 16, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sushi30
sushi30 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@sushi30 sushi30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add reason for changing of customProperties -> customproperties so that it we have it in our commit log.

@TeddyCr
Copy link
Contributor Author

TeddyCr commented Oct 17, 2024 •
edited
Loading

nit: add reason for changing of customProperties -> customproperties so that it we have it in our commit log.

@sushi30 it is already the description of this commit 243afd0

image

@TeddyCr TeddyCr merged commit fc51d7f into open-metadata:main Oct 17, 2024
18 of 19 checks passed
harshach pushed a commit that referenced this pull request Oct 17, 2024
@TeddyCr @harshach
FIX #17042 - Allow non admin/bot to read profiler global config (#18292)
73e2f4c 
* fix: custom properties folder name in generation to match expected package name (i.e. customProperties -- uppercase P)

* fix: allow non admin/bot to read profiler global config with the right permission

* style: ran java linting

* fix: custom properties import casing
harshach pushed a commit that referenced this pull request Oct 19, 2024
@TeddyCr @harshach
FIX #17042 - Allow non admin/bot to read profiler global config (#18292)
6318bb5 
* fix: custom properties folder name in generation to match expected package name (i.e. customProperties -- uppercase P)

* fix: allow non admin/bot to read profiler global config with the right permission

* style: ran java linting

* fix: custom properties import casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@sushi30 sushi30 sushi30 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable reading global profiler settings not only by admins and bots
3 participants
@TeddyCr @harshach @sushi30