Fix npu op bug. #3122
Open
Fix npu op bug. #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zhuweichen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
momo609
force-pushed
the
rc4main
branch
3 times, most recently
from
2ec5da3
to
5189ddd
Compare
HAOCHENYE
reviewed
Jun 17, 2024
| @@ -415,6 +415,8 @@ def nms_rotated(dets: Tensor, | |||
| order = scores.new_empty(0, dtype=torch.long) | |||
| if dets.device.type == 'npu': | |||
| coefficient = 57.29578 # 180 / PI | |||
| dets_cw = dets_cw.float() | |||
There was a problem hiding this comment.
dets.float will return a copy of dets. So , is it necessary to copy dets to dets_cw before?
mmcv/ops/nms.py
Outdated
| @@ -415,6 +415,8 @@ def nms_rotated(dets: Tensor, | |||
| order = scores.new_empty(0, dtype=torch.long) | |||
| if dets.device.type == 'npu': | |||
| coefficient = 57.29578 # 180 / PI | |||
| dets_cw = dets_cw.float() | |||
| scores = scores.float() | |||
There was a problem hiding this comment.
If dets is a float16 tensor, it will be concated with a float32 tensor scores here. Is it expected?
| if torch.cuda.current_device() != points_device: | ||
| torch.cuda.set_device(points_device) | ||
| elif points.device.type == 'npu': | ||
| boxes[:, :, 2] += boxes[:, :, 5] / 2.0 |
There was a problem hiding this comment.
Please leave a comment to describe why we should do this.
momo609
force-pushed
the
rc4main
branch
3 times, most recently
from
c151a35
to
c6478ef
Compare
Update voxelization_npu.cpp Update test_voxelization.py Update voxelization_npu.cpp Update voxelization_npu.cpp Update voxelization_npu.cpp
Add NPU support for dynamic voxelization
repair nms_rotated npu bug
add dtype check for roi_align
Update box_iou_rotated_npu.cpp
Bugfix of NPU adapter of nms3d
Adapt boxes_overlap_bev to box_iou_rotated
fix the bug of DeformableRoiPoolGrad
Interfaces change.
adapt boxes_overlap_bev & box_iou_rotated
points_in_boxes_all的mmcv适配
修改knn与three_nn的适配层代码以适应新版本修改
codeclean npu/boxes_overlap_bev_npu.cpp
adapt npu box_iou_quadri
新增RoiAlignRotatedV2适配层
update point_to_voxel & voxel_to_point in scatter_points.py
add assign_score_withk NPU adaptation
update points_in_boxes_all
border_align算子NPU适配
add new npu op roiaware_pool3d && fix npu op scatter_points bug
pixel_group适配层修改
scatter points bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: