-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add RecorderHook #1300
Open
Xinyu302
wants to merge
39
commits into
open-mmlab:main
Choose a base branch
from
Xinyu302:yxy/recorder-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute by var name
…ify restore forward logic
zhouzaida
reviewed
Sep 19, 2023
mmengine/hooks/recorder_hook.py
Outdated
|
||
|
||
class FunctionRecorderTransformer(ast.NodeTransformer): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docstring and type hint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A glcc summer camp project.
Motivation
The user expects to visualize the output of any layer of the network in the visualization hook, not necessarily the output of nn.module.forward, but also intermediate variables, and will inevitably need to invasively modify the code to update the output into the message hub. Then retrieve the value of the message hub in the visualization hook for visualization. Rather than intrusively modifying the code, we want to have a scheme that can non-intrusively obtain the output of any layer of the network. In addition, it also needs to provide the ability to get properties of a specified instance.
Modification
In short, use ast module to modify the forward function of
runner.model
.Here is a simple example.
The API of RecorderHook is like this:
RecorderHook uses FunctionRecorder and AttributeRecorder to record different things in
forward
method.FunctionRecorder
function
Gets the output and intermediate variables of the specified function or method. If the function has several intermediate variables of the same name
case
Forward method after modification
AttributeRecorder
function
Gets the value of the specified property. Insert the recorder code just at the front of the function.
case
Forward method after modification
A more complicated case
Users can specify the model and function that they want to record.
after modification
TODO