Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch hmr agora #195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Patch hmr agora #195

wants to merge 2 commits into from

Conversation

dldaisy
Copy link

@dldaisy dldaisy commented Jun 8, 2022

Training agora directly with current hmr pipeline would fail, since hmr didn't recenter 3d joints to 0 for agora dataset.
Meanwhile, since smpl kid have 11 dimensions, which is not compatible to smpl neutral/male/female, I think it's better to discard kids data in agora dataset rather than truncating the first 10 dimensions to unify data as done in current code.

@pangyyyyy
Copy link
Collaborator

pangyyyyy commented Jun 27, 2022

Hi @dldaisy, thanks for your inputs!

I did not adopt this 34b047f as it would affect the training for models which uses H36M and MPI-INF-3DHP datasets asleft_hip_extra and right_hip_extra is used to calculate the gt_pelvis. To fix the bug in AGORA, I've centered the 3D keypoints according to the pelvis and added left_hip_extra and right_hip_extra in #202.

I've incorporated your suggestion to remove kid annotations in #202.

Hope this helps, thanks!

@dldaisy
Copy link
Author

dldaisy commented Jun 30, 2022

Great! Thanks for the reply.

@OpenMMLab-Assistant-004

Hi @dldaisy !We are grateful for your efforts in helping improve mmhuman3d open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants