Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] ClsVisualizer compatible with MultiTaskDataSample #1682

Closed
wants to merge 1 commit into from

Conversation

haofengsiji
Copy link

@haofengsiji haofengsiji commented Jun 29, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Jun 30, 2023

Hello, sorry that we don't plan to develop new features on the dev-1.x branch due to staffing constraints, and we'd love for you to migrate this really cool feature to the dev branch.

@Ezra-Yu Ezra-Yu changed the base branch from dev-1.x to dev June 30, 2023 02:07
@Ezra-Yu Ezra-Yu changed the base branch from dev to dev-1.x June 30, 2023 02:07
@haofengsiji haofengsiji closed this Jul 9, 2023
@haofengsiji
Copy link
Author

for dev branch: #1702, @Ezra-Yu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants