Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing device argument in image_demo #1947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asas1asas200
Copy link

Motivation

The motivation for this PR is to fix a missing device argument in the initialization of ImageClassificationInferencer in the image_demo.py script. This fix ensures that the correct device (e.g., CPU or GPU) is specified when running the image classification inference, improving the flexibility and functionality of the script.

Modification

This PR adds the device argument to the ImageClassificationInferencer initialization in image_demo.py. The code change ensures that the model can be run on the specified device provided by the user through the command line arguments.

BC-breaking (Optional)

This modification does not introduce any backward compatibility issues. The change is additive, providing additional functionality without altering existing behavior.

Use cases (Optional)

No new features are introduced in this PR, so no specific use cases are added. However, this fix allows users to specify the computation device for inference, which can be crucial for running models on different hardware setups.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants