Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial part comm tests #27

Closed
wants to merge 1 commit into from

Conversation

adrielpoo
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5940bf3: Initial part comm tests

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@adrielpoo adrielpoo closed this Aug 9, 2023
@jsquyres
Copy link
Member

jsquyres commented Aug 9, 2023

@adrielpoo These tests look useful. Did you mean to close this PR?

@jsquyres jsquyres mentioned this pull request Aug 9, 2023
@adrielpoo
Copy link
Author

@adrielpoo These tests look useful. Did you mean to close this PR?

Hey i just needed to do some last updates and i am currently trying to do the sign off

@jsquyres
Copy link
Member

jsquyres commented Aug 9, 2023

@adrielpoo Ok, gotcha.

Github pro tip: you don't need to close a PR and open a new one; you can just modify your existing PR (which is now #28).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants