Add test cases for panic/OPAL TI for TOD failover recory failure. #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test triggers the TOD topology failover on all the chips to see OPAL TI and panic path to make sure OS does not get stuck while going down. This test needs following skiboot and kernel commit to pass: skiboot: 497734984 opal/hmi: set a flag to inform OS that TOD/TB has failed. ca349b836 opal/hmi: Don't retry TOD recovery if it is already in failed state. 017da88b2 opal/hmi: Fix double unlock of hmi lock in failure path. kernel: http://patchwork.ozlabs.org/patch/1051379/ Signed-off-by: Mahesh Salgaonkar <[email protected]>
Trigger manual OPAL TI by directly setting scom address provided in device-tree node ibm,sw-xstop-fir. This is to test basic functionality of OPAL TI under normal circumstance. Signed-off-by: Mahesh Salgaonkar <[email protected]>
The hang mentioned above on witherspoon is now fixed by skiboot patch at http://patchwork.ozlabs.org/patch/1061289/ |
|
Can you please rebase this PR? -Vasant |
PraveenPenguin
force-pushed
the
master
branch
2 times, most recently
from
4d0cb14 to
b976629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits
Commit 1: hmi: Add test case to trigger TOD topology switch.
Commit 2: Opal TI: Add test for OPAL TI.
Observations:
On Zaius, I see the panic + reboot after HMI failure works fine. But on one of the Witherspoon I have seen hangs in ipmi_msg_sync while dumping dmesg buffer to nvram (pnv_platform_error_reboot->panic_flush_kmsg_end->kmsg_dump->pstore_dump->OPAL..calls..->ipmi_queue_msg_sync). Investigating more to understand why we don't get ipmi timeout which can get systsem out of hang..
On Manual OPAL TI, I see following messages:
3.24326|secure|SecureROM valid - enabling functionality
4.57365|IPMI: shutdown requested
I need to try this on few another system with latest PNOR.
NOTE: The above tests verifies that system reboots successfully after panic or OPAL TI OR else test fails with appropriate error message.
Tests can be run with below option independently:
--run testcases.OpTestHMIHandling.OpalTI
--run testcases.OpTestHMIHandling.TodTopologyFailoverOpalTI
--run testcases.OpTestHMIHandling.TodTopologyFailoverPanic