Update McEliece suppression files for generic config (#1677)

open-quantum-safe · Feb 7, 2024 · dea5170 · dea5170
1 parent f1f11b5
commit dea5170
Show file tree

Hide file tree

Showing 11 changed files with 519 additions and 8 deletions.
diff --git a/.github/workflows/weekly.yml b/.github/workflows/weekly.yml
@@ -16,7 +16,7 @@ jobs:
             container: openquantumsafe/ci-ubuntu-focal-x86_64:latest
             CMAKE_ARGS: -DOQS_DIST_BUILD=OFF -DOQS_OPT_TARGET=generic -DCMAKE_BUILD_TYPE=Debug -DOQS_ENABLE_TEST_CONSTANT_TIME=ON
             PYTEST_ARGS: --numprocesses=auto -k 'test_constant_time'
-            SKIP_ALGS: 'SPHINCS\+-SHA*,Classic-McEliece-(.)*'
+            SKIP_ALGS: 'SPHINCS\+-SHA*,Classic-McEliece-[^3](.)*'
           - name: extensions
             container: openquantumsafe/ci-ubuntu-focal-x86_64:latest
             CMAKE_ARGS: -DOQS_DIST_BUILD=OFF -DOQS_OPT_TARGET=haswell -DCMAKE_BUILD_TYPE=Debug -DOQS_ENABLE_TEST_CONSTANT_TIME=ON

diff --git a/tests/constant_time/kem/issues/classic-mceliece-348864 b/tests/constant_time/kem/issues/classic-mceliece-348864
@@ -365,3 +365,51 @@
    # fun:gen_e
    fun:PQCLEAN_MCELIECE348864_AVX2_encrypt
 }
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:sk_gen.c:58
+   # fun:PQCLEAN_MCELIECE348864_CLEAN_genpoly_gen
+   fun:PQCLEAN_MCELIECE348864_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:66
+   # fun:PQCLEAN_MCELIECE348864_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE348864_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:142
+   # fun:PQCLEAN_MCELIECE348864_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE348864_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:controlbits.c:243
+   # fun:PQCLEAN_MCELIECE348864_CLEAN_controlbitsfrompermutation
+   fun:PQCLEAN_MCELIECE348864_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:69
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE348864_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE348864_CLEAN_crypto_kem_enc
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:84
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE348864_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE348864_CLEAN_crypto_kem_enc
+}
diff --git a/tests/constant_time/kem/issues/classic-mceliece-348864f b/tests/constant_time/kem/issues/classic-mceliece-348864f
@@ -395,4 +395,60 @@
    src:encrypt.c:91
    # fun:gen_e
    fun:PQCLEAN_MCELIECE348864F_AVX2_encrypt
-}
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:sk_gen.c:58
+   # fun:PQCLEAN_MCELIECE348864F_CLEAN_genpoly_gen
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:166
+   # fun:PQCLEAN_MCELIECE348864F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:248
+   # fun:PQCLEAN_MCELIECE348864F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:82
+   # fun:mov_columns
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:controlbits.c:243
+   # fun:PQCLEAN_MCELIECE348864F_CLEAN_controlbitsfrompermutation
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:69
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_crypto_kem_enc
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:84
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE348864F_CLEAN_crypto_kem_enc
+}
diff --git a/tests/constant_time/kem/issues/classic-mceliece-460896 b/tests/constant_time/kem/issues/classic-mceliece-460896
@@ -340,4 +340,52 @@
    src:encrypt.c:91
    # fun:gen_e
    fun:PQCLEAN_MCELIECE460896_AVX2_encrypt
-}
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:sk_gen.c:58
+   # fun:PQCLEAN_MCELIECE460896_CLEAN_genpoly_gen
+   fun:PQCLEAN_MCELIECE460896_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:66
+   # fun:PQCLEAN_MCELIECE460896_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE460896_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:142
+   # fun:PQCLEAN_MCELIECE460896_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE460896_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:controlbits.c:243
+   # fun:PQCLEAN_MCELIECE460896_CLEAN_controlbitsfrompermutation
+   fun:PQCLEAN_MCELIECE460896_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:69
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE460896_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE460896_CLEAN_crypto_kem_enc
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:84
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE460896_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE460896_CLEAN_crypto_kem_enc
+}
diff --git a/tests/constant_time/kem/issues/classic-mceliece-460896f b/tests/constant_time/kem/issues/classic-mceliece-460896f
@@ -501,3 +501,67 @@
    # fun:gen_e
    fun:PQCLEAN_MCELIECE460896F_AVX2_encrypt
 }
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:91
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE460896F_AVX2_encrypt
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:sk_gen.c:58
+   # fun:PQCLEAN_MCELIECE460896F_CLEAN_genpoly_gen
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:166
+   # fun:PQCLEAN_MCELIECE460896F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:248
+   # fun:PQCLEAN_MCELIECE460896F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:82
+   # fun:mov_columns
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:controlbits.c:243
+   # fun:PQCLEAN_MCELIECE460896F_CLEAN_controlbitsfrompermutation
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:69
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_crypto_kem_enc
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:84
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE460896F_CLEAN_crypto_kem_enc
+}
diff --git a/tests/constant_time/kem/issues/classic-mceliece-6688128 b/tests/constant_time/kem/issues/classic-mceliece-6688128
@@ -436,4 +436,52 @@
    src:encrypt.c:91
    # fun:gen_e
    fun:PQCLEAN_MCELIECE6688128_AVX2_encrypt
-}
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:sk_gen.c:58
+   # fun:PQCLEAN_MCELIECE6688128_CLEAN_genpoly_gen
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:66
+   # fun:PQCLEAN_MCELIECE6688128_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:142
+   # fun:PQCLEAN_MCELIECE6688128_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:controlbits.c:243
+   # fun:PQCLEAN_MCELIECE6688128_CLEAN_controlbitsfrompermutation
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:69
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_crypto_kem_enc
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:84
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE6688128_CLEAN_crypto_kem_enc
+}
diff --git a/tests/constant_time/kem/issues/classic-mceliece-6688128f b/tests/constant_time/kem/issues/classic-mceliece-6688128f
@@ -736,3 +736,58 @@
    fun:PQCLEAN_MCELIECE6688128F_AVX2_encrypt
 }
 
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:sk_gen.c:58
+   # fun:PQCLEAN_MCELIECE6688128F_CLEAN_genpoly_gen
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:166
+   # fun:PQCLEAN_MCELIECE6688128F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:248
+   # fun:PQCLEAN_MCELIECE6688128F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_crypto_kem_keypair
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:pk_gen.c:82
+   # fun:mov_columns
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_pk_gen
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:controlbits.c:243
+   # fun:PQCLEAN_MCELIECE6688128F_CLEAN_controlbitsfrompermutation
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_crypto_kem_keypair
+}
+
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:69
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_crypto_kem_enc
+}
+{
+   This implementation of Classic McEliece may not be constant time.
+   Memcheck:Cond
+   src:encrypt.c:84
+   # fun:gen_e
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_encrypt
+   fun:PQCLEAN_MCELIECE6688128F_CLEAN_crypto_kem_enc
+}