Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Classic McEliece suppression files #1541

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Update Classic McEliece suppression files #1541

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f25f34
Update McEliece supression files.
praveksharma Sep 7, 2023
38fbdc4
Update McEliece advisories.
praveksharma Sep 7, 2023
91c6818
Update weekly constant time test workflow.
praveksharma Sep 7, 2023
b4e1b0c
Update weekly constant time test workflow. Update McEliece supression…
praveksharma Sep 11, 2023
60a3778
Update BIKE advisories.
praveksharma Sep 11, 2023
62e2ec6
Restored BIKE advisories. Deleted unused BIKE supressions.
praveksharma Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
container: openquantumsafe/ci-ubuntu-focal-x86_64:latest
CMAKE_ARGS: -DOQS_OPT_TARGET=generic -DCMAKE_BUILD_TYPE=Debug -DOQS_ENABLE_TEST_CONSTANT_TIME=ON
PYTEST_ARGS: --numprocesses=auto -k 'test_constant_time'
SKIP_ALGS: 'SPHINCS\+-SHA*,Classic-McEliece-6(.)*'
SKIP_ALGS: 'SPHINCS\+-SHA*'
- name: extensions
container: openquantumsafe/ci-ubuntu-focal-x86_64:latest
CMAKE_ARGS: -DOQS_OPT_TARGET=haswell -DCMAKE_BUILD_TYPE=Debug -DOQS_ENABLE_TEST_CONSTANT_TIME=ON
Expand Down
1 change: 1 addition & 0 deletions docs/algorithms/kem/classic_mceliece.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
## Advisories

- Classic-McEliece-460896, Classic-McEliece-460896f, Classic-McEliece-6960119, and Classic-McEliece-6960119f parameter sets fail memory leak testing on x86-64 when building with ``clang`` using optimization level ``-O2`` and ``-O3``. Care is advised when using the algorithm at higher optimization levels, and any other compiler and architecture.
- Current implementation of the algorithm may not be constant-time. Additionally, environment specific constant-time leaks may not be documented; please report potential constant-time leaks when found.
baentsch marked this conversation as resolved.
Show resolved Hide resolved

## Parameter set summary

Expand Down
16 changes: 16 additions & 0 deletions tests/constant_time/kem/issues/classic-mceliece-348864
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,14 @@
fun:PQCLEAN_MCELIECE348864_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
src:pk_gen.c:314
# fun:PQCLEAN_MCELIECE348864_AVX2_pk_gen
fun:PQCLEAN_MCELIECE348864_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
Expand Down Expand Up @@ -166,6 +174,14 @@
fun:PQCLEAN_MCELIECE348864_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Cond
src:pk_gen.c:322
# fun:PQCLEAN_MCELIECE348864_AVX2_pk_gen
fun:PQCLEAN_MCELIECE348864_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
Expand Down
40 changes: 40 additions & 0 deletions tests/constant_time/kem/issues/classic-mceliece-460896
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
src:pk_gen.c:35
# fun:extract_01_masks
fun:PQCLEAN_MCELIECE460896_AVX2_pk_gen
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
src:pk_gen.c:43
# fun:extract_mask256
fun:PQCLEAN_MCELIECE460896_AVX2_pk_gen
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
Expand Down Expand Up @@ -30,6 +46,14 @@
fun:PQCLEAN_MCELIECE460896_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
src:pk_gen.c:315
# fun:PQCLEAN_MCELIECE460896_AVX2_pk_gen
fun:PQCLEAN_MCELIECE460896_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Cond
Expand All @@ -38,6 +62,22 @@
fun:PQCLEAN_MCELIECE460896_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
src:pk_gen.c:320
# fun:PQCLEAN_MCELIECE460896_AVX2_pk_gen
fun:PQCLEAN_MCELIECE460896_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
src:pk_gen.c:323
# fun:PQCLEAN_MCELIECE460896_AVX2_pk_gen
fun:PQCLEAN_MCELIECE460896_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
Expand Down
8 changes: 8 additions & 0 deletions tests/constant_time/kem/issues/classic-mceliece-6960119
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@
fun:PQCLEAN_MCELIECE6960119_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Value8
src:pk_gen.c:326
# fun:PQCLEAN_MCELIECE6960119_AVX2_pk_gen
fun:PQCLEAN_MCELIECE6960119_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Cond
Expand Down
8 changes: 8 additions & 0 deletions tests/constant_time/kem/issues/classic-mceliece-8192128
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@
fun:PQCLEAN_MCELIECE8192128_AVX2_crypto_kem_keypair
}

{
<insert_a_suppression_name_here>
Memcheck:Value8
src:pk_gen.c:323
# fun:PQCLEAN_MCELIECE8192128_AVX2_pk_gen
fun:PQCLEAN_MCELIECE8192128_AVX2_crypto_kem_keypair
}

{
This implementation of Classic McEliece may not be constant time.
Memcheck:Cond
Expand Down
Loading