Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable erroring TravisCI build #1901

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Disable erroring TravisCI build #1901

merged 1 commit into from
Aug 22, 2024

Conversation

bhess
Copy link
Member

@bhess bhess commented Aug 22, 2024

Since TravisCI is failing since 2 weeks (#1888) and the ticket there is still under investigation, I'd suggest to disable it temporarily to not longer interrupt the liboqs CI pipeline.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@bhess bhess requested a review from dstebila as a code owner August 22, 2024 08:06
@bhess bhess requested review from SWilson4 and dstebila and removed request for dstebila August 22, 2024 08:06
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely agree -- big surprise as this is actually implementing part of the proposal in #1745 (comment) :). The completion on this line item would be creation of an issue to add Travis back eventually (if someone cares about those platforms).

@bhess bhess merged commit 6a24482 into main Aug 22, 2024
46 checks passed
@bhess bhess deleted the bhe-travis-disable branch August 22, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants