Don't include dlfcn.h for Windows #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also check #1768 @andybrucenet |
|
Thanks for the PR! I've approved the workflow run, though I can't imagine that this change will cause any test failures. Please address the DCO failure. |
Thanks for remember #1768, @pi-314159. Would it be the case that this PR should resolve #1768? |
Signed-off-by: Steen Rasmussen <[email protected]>
steenrasmussen
force-pushed
the
include-dlfcn-for-non-windows-platforms-only
branch
from
6b2aea3
to
a34495c
Compare
|
This change will solely allow liboqs to build successfully on Windows. Implementing direct Windows support either with native APIs or through a compatibility layer as #1768 also suggests may still be needed but as-is these code-paths does not appear to be included for Windows. |
dstebila
approved these changes
Sep 30, 2024
SWilson4
approved these changes
Sep 30, 2024
ashman-p
pushed a commit
to ashman-p/liboqs-lms
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Steen Rasmussen <[email protected]> Co-authored-by: Steen Rasmussen <[email protected]> Signed-off-by: Norman Ashley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dlfcn.h is a Posix library not natively available on Windows. Only include the header for non-Windows builds.
Fixes #1935