Skip to content

Commit

Permalink
Update x25519_mlkem768 code point
Browse files Browse the repository at this point in the history
Signed-off-by: Basil Hess <[email protected]>
  • Loading branch information
bhess committed Sep 19, 2024
1 parent 95e3ab2 commit 78e34ff
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion ALGORITHMS.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ As standardization for these algorithms within TLS is not done, all TLS code poi
| mlkem768 | 0x0768 | Yes | OQS_CODEPOINT_MLKEM768 |
| p384_mlkem768 | 0x2F4C | Yes | OQS_CODEPOINT_P384_MLKEM768 |
| x448_mlkem768 | 0x2FB7 | Yes | OQS_CODEPOINT_X448_MLKEM768 |
| x25519_mlkem768 | 0x2FB8 | Yes | OQS_CODEPOINT_X25519_MLKEM768 |
| x25519_mlkem768 | 0x11ec | Yes | OQS_CODEPOINT_X25519_MLKEM768 |
| p256_mlkem768 | 4587 | Yes | OQS_CODEPOINT_P256_MLKEM768 |
| mlkem1024 | 0x1024 | Yes | OQS_CODEPOINT_MLKEM1024 |
| p521_mlkem1024 | 0x2F4D | Yes | OQS_CODEPOINT_P521_MLKEM1024 |
Expand Down
3 changes: 1 addition & 2 deletions oqs-template/generate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,8 @@ kems:
- hybrid_group: "x448"
# code point not standardized: Why? XXX
nid: '0x2FB7'
# To change when hybrid order change implemented, see https://github.com/open-quantum-safe/oqs-provider/issues/503
- hybrid_group: "x25519"
nid: '0x2FB8'
nid: '0x11ec'
- hybrid_group: "p256"
# https://www.ietf.org/archive/id/draft-kwiatkowski-tls-ecdhe-mlkem-01.html#name-iana-considerations
nid: '4587'
Expand Down
2 changes: 1 addition & 1 deletion oqs-template/oqs-kem-info.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
| ML-KEM | ML-KEM | mlkem512 | FIPS203 | 1 | 0x2F4B | secp256_r1 |
| ML-KEM | ML-KEM | mlkem512 | FIPS203 | 1 | 0x2FB6 | x25519 |
| ML-KEM | ML-KEM | mlkem768 | FIPS203 | 3 | 0x0768 | |
| ML-KEM | ML-KEM | mlkem768 | FIPS203 | 3 | 0x11ec | x25519 |
| ML-KEM | ML-KEM | mlkem768 | FIPS203 | 3 | 0x2F4C | secp384_r1 |
| ML-KEM | ML-KEM | mlkem768 | FIPS203 | 3 | 0x2FB7 | x448 |
| ML-KEM | ML-KEM | mlkem768 | FIPS203 | 3 | 0x2FB8 | x25519 |
| ML-KEM | ML-KEM | mlkem768 | FIPS203 | 3 | 4587 | p256 |
2 changes: 1 addition & 1 deletion oqsprov/oqsprov_capabilities.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ static OQS_GROUP_CONSTANTS oqs_group_list[] = {

{0x2F4C, 192, TLS1_3_VERSION, 0, -1, -1, 1},
{0x2FB7, 192, TLS1_3_VERSION, 0, -1, -1, 1},
{0x2FB8, 192, TLS1_3_VERSION, 0, -1, -1, 1},
{0x11ec, 192, TLS1_3_VERSION, 0, -1, -1, 1},
{4587, 192, TLS1_3_VERSION, 0, -1, -1, 1},
{0x1024, 256, TLS1_3_VERSION, 0, -1, -1, 1},

Expand Down
4 changes: 1 addition & 3 deletions scripts/oqsprovider-externalinterop.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ fi
# Ascertain algorithms are available:

# skipping these tests for now as per https://mailarchive.ietf.org/arch/msg/tls/hli5ogDbUudAA4tZXskVbOqeor4
# TBD replace with suitable ML-KEM hybrid tests as and when available XXX

exit 0
# TBD replace with suitable ML-KEM hybrid tests as and when available XXX

echo " Cloudflare:"

Expand Down

2 comments on commit 78e34ff

@ghen2
Copy link

@ghen2 ghen2 commented on 78e34ff Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This x25519_mlkem768 is interoperable with the one from Firefox 132 nightly.

@baentsch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This x25519_mlkem768 is interoperable with the one from Firefox 132 nightly.

Thanks for the test, @ghen2 ! So boringssl and Firefox agree. Now need to see how to deal with Cloudflare (or whether to keep that at Kyber (???)...

Please sign in to comment.