Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Windows CI to work again #310

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Get Windows CI to work again #310

merged 2 commits into from
Dec 7, 2023

Conversation

qnfm
Copy link
Contributor

@qnfm qnfm commented Dec 6, 2023

Fixes #290 #291

The architecture of OpenSSL building is wrong

@qnfm qnfm requested a review from baentsch as a code owner December 6, 2023 16:36
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent -- Thanks very much! Just wonder -- if architecture spec'd is wrong, why did "Release" work OK? And why did CI pass until a few weeks ago?

@qnfm
Copy link
Contributor Author

qnfm commented Dec 6, 2023

Probably due to previously cached OpenSSL build

if: steps.cache-openssl32.outputs.cache-hit != 'true'

@baentsch
Copy link
Member

baentsch commented Dec 7, 2023

Probably due to previously cached OpenSSL build

Don't think so -- I killed all caches when trying to get #306 to pass CI. But whatever -- main thing is it works now.

@baentsch baentsch merged commit 99f4271 into open-quantum-safe:main Dec 7, 2023
23 checks passed
@qnfm qnfm deleted the winci branch December 13, 2023 11:23
@qnfm qnfm restored the winci branch December 13, 2023 11:23
baentsch pushed a commit that referenced this pull request Dec 23, 2023
* Change osslconfig for Windows build

* Re-activate Debug build
baentsch pushed a commit that referenced this pull request Dec 24, 2023
* Change osslconfig for Windows build

* Re-activate Debug build
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 13, 2024
* Change osslconfig for Windows build

* Re-activate Debug build

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
* Change osslconfig for Windows build

* Re-activate Debug build

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
* Change osslconfig for Windows build

* Re-activate Debug build

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
* Change osslconfig for Windows build

* Re-activate Debug build

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
* Change osslconfig for Windows build

* Re-activate Debug build

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
* Change osslconfig for Windows build

* Re-activate Debug build

Signed-off-by: Felipe Ventura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSVC native CI failing
2 participants