Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actionlint workflow checking #516

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Actionlint workflow checking #516

merged 2 commits into from
Sep 12, 2024

Conversation

jplomas
Copy link
Contributor

@jplomas jplomas commented Sep 12, 2024

Based on open-quantum-safe/liboqs#1916, this integrates Actionlint checking of GitHub workflows for errors as part of CI. This also fixes issues highlighted in other workflows, primarily the checkout version and missing property.

For completeness, the actionlint output for the workflows before the fixes applied in this PR:

| .github/workflows/coding_style.yml:17:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|    |
| 17 |         uses: actions/checkout@v2
|    |               ^~~~~~~~~~~~~~~~~~~
| .github/workflows/linux.yml:26:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|    |
| 26 |         uses: actions/checkout@v2
|    |               ^~~~~~~~~~~~~~~~~~~
| .github/workflows/linux.yml:56:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|    |
| 56 |         uses: actions/checkout@v2
|    |               ^~~~~~~~~~~~~~~~~~~
| .github/workflows/linux.yml:106:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|     |
| 106 |         uses: actions/checkout@v2
|     |               ^~~~~~~~~~~~~~~~~~~
| .github/workflows/linux.yml:180:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|     |
| 180 |         uses: actions/checkout@v2
|     |               ^~~~~~~~~~~~~~~~~~~
| .github/workflows/standalone.yml:21:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|    |
| 21 |         uses: actions/checkout@v2
|    |               ^~~~~~~~~~~~~~~~~~~
| .github/workflows/standalone.yml:49:15: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
|    |
| 49 |         uses: actions/checkout@v2
|    |               ^~~~~~~~~~~~~~~~~~~
| .github/workflows/windows.yml:60:60: property "config" is not defined in object type {arch: string; oqsconfig: string} [expression]
|    |
| 60 |         run: bash -c "./config --prefix=/opt/openssl32 ${{ matrix.platform.config }} && perl configdata.pm --dump && make $MAKE_PARAMS && make install_sw"
|    |                                                            ^~~~~~~~~~~~~~~~~~~~~~
[Check GitHub workflows/Check validity of GitHub workflows]   ❌  Failure - Main Ensure GitHub actions are valid

Integrate Actionlint to check GitHub workflows for errors as part of CI. It also fixes issues highlighted in other workflows, primarily the `checkout` version and missing property.

Signed-off-by: JP Lomas <[email protected]>
@jplomas jplomas marked this pull request as ready for review September 12, 2024 09:27
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Much appreciated, @jplomas !

@baentsch
Copy link
Member

Before landing this, just a question whether you'd be interested to help this project more long term and would want to add yourself as part of this PR to

/.github/workflows @baentsch @thb-sb

@jplomas ?

Signed-off-by: JP Lomas <[email protected]>
@jplomas
Copy link
Contributor Author

jplomas commented Sep 12, 2024

Before landing this, just a question whether you'd be interested to help this project more long term and would want to add yourself as part of this PR to

/.github/workflows @baentsch @thb-sb

@jplomas ?

Happy to help where I can.

@baentsch baentsch merged commit 38aaf69 into open-quantum-safe:main Sep 12, 2024
27 checks passed
ashman-p pushed a commit to ashman-p/oqs-provider-fix-warnings that referenced this pull request Sep 13, 2024
* Actionlint workflow checking

Integrate Actionlint to check GitHub workflows for errors as part of CI. It also fixes issues highlighted in other workflows, primarily the `checkout` version and missing property.

Signed-off-by: JP Lomas <[email protected]>

* Update CODEOWNERS

Signed-off-by: JP Lomas <[email protected]>

---------

Signed-off-by: JP Lomas <[email protected]>
Signed-off-by: Norman Ashley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants