Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define new Phase Descriptions #43

Open
8 tasks
mxgrey opened this issue Sep 29, 2021 · 1 comment
Open
8 tasks

Define new Phase Descriptions #43

mxgrey opened this issue Sep 29, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Sep 29, 2021

As part of open-rmf/rmf_ros2#107 we should start defining the Descriptions of the new Phase types.

We could start immediately on these task types:

  • PerformAction (we will need the Description to have a parameter for an estimated duration for the action)
  • ParkUntil (we will need the Description to have a parameter for an estimated duration of the parking)
  • Call
  • SMS
  • RepeatN
  • While (we will need the Description to have a parameter for an estimated number of repetitions so the planner can deal with this phase)
  • ParallelGroup

This phase will require #42 before we can support it:

  • RepeatIndefinitely

The APIs for these different phase Descriptions should be put into the rmf_task_sequence/phases include directory.

@mxgrey
Copy link
Contributor Author

mxgrey commented Sep 29, 2021

On this topic, maybe the Phases that are supposed to be repeaters shouldn't be phases, but instead we should incorporate it into the rmf_task_sequence::Task::Builder API, e.g. by providing add_repeated_phase and add_phase_while functions.

@Yadunund Yadunund self-assigned this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants