Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : refactoring footer component #531

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

sohaibchebah
Copy link

@sohaibchebah sohaibchebah commented Aug 16, 2024

Description

This PR refactor the footer component by moving the footer context to separate file for more readability to components

Related Tickets & Documents

feat #532

Mobile & Desktop Screenshots/Recordings

N/A

Steps to QA

N/A

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

This PR adds more accessibility to the hero section and also seo bost becuase search engine crawlers
understand more the semantic html

feat open-sauced#530
this pr refactor code inside the footer componenet and move the constant footercontext to seperate
file inside the constants folder i have created to add more readibility to the code
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for hot-sauced-ui ready!

Name Link
🔨 Latest commit 3dc12ea
🔍 Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/66bf2f3b11799300082c2e6d
😎 Deploy Preview https://deploy-preview-531--hot-sauced-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant