Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sort init_s0 on generating from r_s0_default #139

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix/sort init_s0 on generating from r_s0_default #139

merged 1 commit into from
Dec 19, 2023

Conversation

L-M-Sherlock
Copy link
Member

No description provided.

@L-M-Sherlock L-M-Sherlock added the bug Something isn't working label Dec 19, 2023
@asukaminato0721
Copy link
Collaborator

asukaminato0721 commented Dec 19, 2023 •
edited
Loading

There is always a thought: can this rating_stability be [Option<f32>; 5] ?

leave it be another pr or issue. Unimportant now.

@asukaminato0721 asukaminato0721 merged commit 3d785fc into main Dec 19, 2023
3 checks passed
@asukaminato0721 asukaminato0721 deleted the Fix/order-of-init_s0-from-r_s0_default branch December 19, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asukaminato0721 asukaminato0721 asukaminato0721 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-M-Sherlock @asukaminato0721