Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Simulator learn affects review limit option #267

Conversation

Luc-Mcgrady
Copy link
Member

What I was talking about here: #262 (review)

Implemented in Anki: https://github.com/Luc-Mcgrady/anki/tree/simulator-new-ignores-review-limit

Orange = true
Blue = false

Breaking but small change so I'd recommend waiting for something more important before merging

@L-M-Sherlock
Copy link
Member

It introduced a breaking change in simulate API. I consider to include it and #258 in v2.0.0.

@L-M-Sherlock L-M-Sherlock merged commit b06352d into open-spaced-repetition:main Jan 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants